-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added auto-decoding special case to std.algorithm.comparison.equal #4394
Conversation
|
This is somehow making std.socket segfault. |
|
has anyone an idea why Travis is not displayed anymore? :O |
| // can be avoided if they have the same ElementEncodingType | ||
| else static if (is(typeof(pred) == string) && pred == "a == b" && | ||
| anySatisfy!(isSomeString, Range1, Range2) && | ||
| anySatisfy!(templateNot!isSomeString, Range1, Range2) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean "exactly one of Range1 and Range2 is a string?" In that case: isSomeString!Range1 != isSomeString!Range2
|
Fixed |
| @@ -61,7 +61,7 @@ import std.range.primitives; | |||
| import std.traits; | |||
| // FIXME | |||
| import std.typecons; // : tuple, Tuple, Flag; | |||
| import std.meta : allSatisfy; | |||
| import std.meta; // : allSatisfy, anySatisfy; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add the // ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when the transition period for issues 313/314 is over, all of the imports can be fixed by just removing the //. This has been done to a lot of files recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the common style in Phobos as I think the idea is that we can use a simple regex to flip the switch once the deprecation period for the exposed import is over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this was released, don't comment it out. The idea is to keep things the same, not to remove the leak.
|
Fixed |
|
Thanks! |
No description provided.