Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auto-decoding special case to std.algorithm.comparison.equal #4394

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

JackStouffer
Copy link
Member

No description provided.

@JackStouffer
Copy link
Member Author

This is somehow making std.socket segfault.

@wilzbach
Copy link
Member

wilzbach commented Jun 2, 2016

has anyone an idea why Travis is not displayed anymore? :O

// can be avoided if they have the same ElementEncodingType
else static if (is(typeof(pred) == string) && pred == "a == b" &&
anySatisfy!(isSomeString, Range1, Range2) &&
anySatisfy!(templateNot!isSomeString, Range1, Range2) &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean "exactly one of Range1 and Range2 is a string?" In that case: isSomeString!Range1 != isSomeString!Range2

@JackStouffer
Copy link
Member Author

Fixed

@@ -61,7 +61,7 @@ import std.range.primitives;
import std.traits;
// FIXME
import std.typecons; // : tuple, Tuple, Flag;
import std.meta : allSatisfy;
import std.meta; // : allSatisfy, anySatisfy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add the // ?

Copy link
Member Author

@JackStouffer JackStouffer Jun 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So when the transition period for issues 313/314 is over, all of the imports can be fixed by just removing the //. This has been done to a lot of files recently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the common style in Phobos as I think the idea is that we can use a simple regex to flip the switch once the deprecation period for the exposed import is over.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was released, don't comment it out. The idea is to keep things the same, not to remove the leak.

@JackStouffer
Copy link
Member Author

Fixed

@WalterBright WalterBright merged commit a85f48a into dlang:master Jun 7, 2016
@JackStouffer
Copy link
Member Author

Thanks!

@JackStouffer JackStouffer deleted the equal branch June 7, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants