std.conv, rangify the hexString template and add a run-time overload #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 28, 2016
•
ghost
commented
- the template and the run-time version always take an input range (vs always a string previously)
- verify safety and purity in the unittests
- the result of the runtime version is itself an input range
This will fail to decode input ranges, so things like You also need tests using input ranges. |
|
@JackStouffer, fixed. |
| if (hexData.isHexLiteral) | ||
| { | ||
| immutable hexString = hexStrImpl(hexData); | ||
| import std.array: array; |
There was a problem hiding this comment.
Needs space before : says style guide
+ verify safety and purity of the unittests + the output of the runtime version is itself an input range
|
@klickverbot , initially when I've made the template you told me it's just a matter of time before people complain it's not an input range. Fixed now. |
ghost
closed this
ghost
deleted the
|
ping @WalterBright (https://forum.dlang.org/post/p5gaj5$1hqf$1@digitalmars.com) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.