let transcode accept mutable/const characters #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.74% (diff: 100%)@@ master #4722 diff @@
==========================================
Files 121 121
Lines 74037 74037
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 65705 65704 -1
- Misses 8332 8333 +1
Partials 0 0
|
|
LGTM |
|
urgh what an awful function... thanks for improving it |
|
Auto-merge toggled on |
Indeed. The whole module... |
Seems like there is an overall consensus on this - see also this recent discussion http://forum.dlang.org/post/mailman.793.1470702307.3131.digitalmars-d@puremagic.com ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because requiring immutable characters doesn't make sense.
See also http://forum.dlang.org/post/noashv$1bgv$1@digitalmars.com.
The second commit ("remove pointless variable t") is just a little cleanup I noticed when looking at this.