Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

std.stdio: Need to check ret != -1, not ret == 0 #487

Merged
merged 1 commit into from Mar 11, 2012

Conversation

Projects
None yet
2 participants
Contributor

jpf91 commented Mar 11, 2012

Using std.process.shell produces this error:

std/stdio.d(419): Could not close pipe `./a.out' (Success)

The return value check has to check for != -1, not == 0, see http://linux.die.net/man/3/pclose

braddr added a commit that referenced this pull request Mar 11, 2012

Merge pull request #487 from jpf91/patch-1
std.stdio: Need to check ret != -1, not ret == 0

@braddr braddr merged commit bc13258 into dlang:master Mar 11, 2012

@schveiguy schveiguy referenced this pull request in schveiguy/phobos Apr 15, 2012

Merged

std.process ready for review? #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment