Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable{,Ref} construction functions #4989

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

wilzbach
Copy link
Member

Such construction helpers are there for literally every other type in Phobos, even in the same module, e.g. refCounted, rebindable, tuple - so I assume it was just forgotten?

@dukc
Copy link
Contributor

dukc commented Dec 23, 2016

Everything seems correct to me. Good work.

@wilzbach
Copy link
Member Author

Everything seems correct to me. Good work.

Thanks!
Btw I am trying to move a bit of stuff and ideas from phobos-next to mainline Phobos. If you (or someone else), has time - please see this issue and the filtered TODO wiki

@UplinkCoder
Copy link
Member

please don't change existing unittest if there are no semantic reasons to do so.
unit-tests should be extended, not modified.

@wilzbach
Copy link
Member Author

please don't change existing unittest if there are no semantic reasons to do so.
unit-tests should be extended, not modified.

Those are public unittest that are shown to the user in the documentation. Hence it does make sense to update the style there. Most users will just copy / paste the first example in the documentation.

Copy link
Member

@UplinkCoder UplinkCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this is a trivial and helpful change. No reason not to merge it

@UplinkCoder
Copy link
Member

Auto-merge toggled on

@UplinkCoder UplinkCoder merged commit 085e41e into dlang:master Dec 27, 2016
@nordlow
Copy link
Contributor

nordlow commented Dec 27, 2016

Thanks, @wilzbach!

@wilzbach wilzbach deleted the add-nullable-helper branch February 19, 2017 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants