Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircleCi]: use more fallbacks in case of a failure #5012

Merged
merged 1 commit into from Feb 14, 2017

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Jan 4, 2017

@DmitryOlshansky
Copy link
Member

I know nothing about CircleCI automation but this looks sensible

@wilzbach
Copy link
Member Author

I know nothing about CircleCI automation but this looks sensible

It's behaves like ever other CI provider: on every synchronize event of a PR, they trigger a new build.
It's used here to do static code analysis via Dscanner (the style Makefile target)
Moreover, it runs all unittests with coverage logging enabled and uploads the results to CodeCov.

All in all the build is executed with the circleci.sh Bash script which then does a bit of bootstrapping. Most importantly this is

  1. cloning the DMD and Druntime repo
  2. merging the upstream Phobos branch (this requires an API call to the GitHub API which can run into rate limits)
  3. download and install a DMD compiler

As mentioned above this adds fallbacks for download errors occurring at step 2 or 3 of the bootstrap phase.

Copy link
Member

@DmitryOlshansky DmitryOlshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

@DmitryOlshansky DmitryOlshansky merged commit 70ea6a1 into dlang:master Feb 14, 2017
@wilzbach wilzbach deleted the circleci-use-more-fallbacks branch February 19, 2017 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants