std.file: Use GetFileAttributesEx to query file attributes on Windows #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindFirstFile and CreateFile may fail in certain circumstances when GetFileAttributesEx would succeed - for example, if the user doesn't have directory listing permissions on the object's containing directory.
|
You're going to need to merge in the latest head (or rebase these changes on top of it), since there appear to be merge conflicts. |
Conflicts: std/file.d
Deleting and immediately recreating a file doesn't seem to always reset the file creation time.
|
Done (also disabled a minor test that failed on my machine). |
jmdavis
added a commit
that referenced
this pull request
May 6, 2012
std.file: Use GetFileAttributesEx to query file attributes on Windows
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindFirstFile and CreateFile may fail in certain circumstances when GetFileAttributesEx would succeed - for example, if the user doesn't have directory listing permissions on the object's containing directory.
GetFileAttributesEx is available on Windows versions starting with Windows 98.
Needs Druntime pull request 190.