Remove unused debug writelns in std.algorithm #5180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
reviewed
Feb 22, 2017
There was a problem hiding this comment.
I assume that this cruft is a relict from times in which D wasn't that stable, so I leave this to someone with a longer history to sign off.
FWIW I think that a beautiful language (and D tries to be one) shouldn't require such redundancy for such a "simple" feature of reporting unittest results.
I am still hoping to see DIP83 come alive at some point...
std/algorithm/mutation.d
Outdated
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| assert(remove!(SwapStrategy.stable)(a, 1, 3, 5) | ||
| == [ 0, 2, 4, 6, 7, 8, 9, 10]); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| //writeln(remove!(SwapStrategy.stable)(a, 1, tuple(3, 5))); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; |
There was a problem hiding this comment.
This line can then be removed as well?
std/algorithm/mutation.d
Outdated
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| assert(remove!(SwapStrategy.stable)(a, 1, 5) == | ||
| [ 0, 2, 3, 4, 6, 7, 8, 9, 10 ]); | ||
|
|
||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| //writeln(remove!(SwapStrategy.stable)(a, 1, 3, 5)); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; |
There was a problem hiding this comment.
This line can then be removed as well?
std/algorithm/mutation.d
Outdated
| @@ -1871,18 +1850,15 @@ if (s == SwapStrategy.stable | |||
| [ 1, 2, 4 ]); | |||
|
|
|||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | |||
| //writeln(remove!(SwapStrategy.stable)(a, 1, 5)); | |||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | |||
There was a problem hiding this comment.
This line can then be removed as well?
JackStouffer
force-pushed
the
algorithm-cruft
branch
2 times, most recently
from
5b953ed
to
9214a85
Compare
ghost
approved these changes
Feb 24, 2017
|
That code was mightily useful back in the days when dmd had more bugs than features :) |
andralex
approved these changes
Feb 28, 2017
JackStouffer
force-pushed
the
algorithm-cruft
branch
from
9214a85
to
2e90b8b
Compare
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These didn't even work because std.stdio wasn't imported. I highly doubt anyone was using them, and they're not particularly useful anyway.