Fix Issue 17231 and Improve std.concurrency.locate #5205
Conversation
|
std/concurrency.d
Outdated
| if (auto name = tid in namesByTid) | ||
| return *name; | ||
| return null; | ||
| } |
There was a problem hiding this comment.
suggestion: replace the whole implementation with
synchronized (registryLock)
return namesByTid.get(tid, null);
std/concurrency.d
Outdated
| @@ -1076,6 +1076,24 @@ Tid locate( string name ) | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Gets all of the names associated with the $(LREF Tid). | |||
There was a problem hiding this comment.
Suggest: Gets an array of all
std/concurrency.d
Outdated
| * tid = The $(LREF Tid) to locate within the registry. | ||
| * | ||
| * Returns: | ||
| * The associated name or `null` if `tid` is not registered. |
There was a problem hiding this comment.
Suggest: An array of the associated names
|
Would be nice to have a See Also section for the inverse and registering functions |
|
Also, unittests |
|
@John-Colvin Fixed |
std/concurrency.d
Outdated
| { | ||
| auto id = thisTid(); | ||
| assert(register("Main", id)); | ||
| assert(locate(id) == ["Main"]); |
There was a problem hiding this comment.
This will fail if another unittest (or static this) has registered anything for the main thread. If you think that matters, you could wrap the whole unittest in spawn so you know you'll have a new id.
|
@John-Colvin Fixed again. Also added example for the other overload |
JackStouffer
force-pushed
the
issue17231
branch
2 times, most recently
from
c15445d to
c9260ac
Compare
|
Lgtm. If you want to do a real belt and braces job, check for what happens when there aren't any names registered, if an incorrect name is passed in, check that multiple names are all reported correctly etc. |
JackStouffer
changed the title
|
|
|
which is odd, because I developed this patch on macOS |
JackStouffer
force-pushed
the
issue17231
branch
from
c9260ac to
4f481ab
Compare
|
I don't really have time to fix this right now, so closing |
Brought up in https://forum.dlang.org/post/zvhzxmqeponyhtphqbsb@forum.dlang.org