-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make behavior of environment.opIndexAssign on Posix to match the behavior on Windows #5324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a simple change and I don't have a strong opinion about this, but as no one has bother to look at this so far, here are a couple of comments:
according to SetEnvironmentVariable documentation while Posix leaves unspecified what setenev should do
For the lazy ones: https://msdn.microsoft.com/en-us/library/windows/desktop/ms686206(v=vs.85).aspx
=> The idea of unifying the behavior seems appealing, it comes with a very low cost and probably doesn't hurt anyone.
Has anyone a (strong) opinion about this?
| @@ -3103,6 +3103,7 @@ static: | |||
| /** | |||
| Assigns the given $(D value) to the environment variable with the given | |||
| $(D name). | |||
| If $(D value) is null the variable is removed from environment. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: null as its code as well
|
This is a bug fix, as current behavior on posix is sending a SIGTERM when null is set. |
|
Vibe.d seems to have a transient error? Does the new Project Tester already support restarting builds or do we need to kick him manually with a git rebase? |
|
I don't see a way to restart it. @MartinNowak Can return Jenkins to not required for merging until it's more stable? |
…vior on Windows. Setting null as environment value leads to removing this variable according to SetEnvironmentVariable documentation while Posix leaves unspecified what setenev should do if value is null.
I rebased the PR manually, s.t. hopefully it can be auto-merged. |
Setting null as environment value leads to removing this variable
according to SetEnvironmentVariable documentation while Posix leaves
unspecified what setenev should do if value is null.