Issue 7909 - to!enum(string) and to!string(enum) break when enum is integral #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string based enum to string conversion should return member name, instead of base value.
| @@ -101,6 +101,12 @@ private | |||
| formatValue(w, src, f); | |||
| return w.data; | |||
| } | |||
|
|
|||
| template isEnumStrToStr(S, T) // @@@Workaround@@@ | |||
There was a problem hiding this comment.
Please document what is being worked around.. specifically, what bug number?
There was a problem hiding this comment.
Sorry, this is NOT workaround. I'll remove this meaningless comment.
|
I don't feel qualified to review most of phobos, however, commit 52462be feels rather intrusive. Since it's a regression fix, would someone else put eyes on this and let's get it done? |
| assert(to!wstring(F.y) == "y"w); | ||
| assert(to!dstring(F.z) == "z"d); | ||
| enum EB { a = true } | ||
| enum EU { a = 0, b = 1, c = 2 } // base type is unsigned |
There was a problem hiding this comment.
Isn't the base type still int, not uint, because you didn't specify? If that's the case, the base type is not unsigned.
There was a problem hiding this comment.
Yes, you're right. I couldn't remember why I added that comment in here and didn't add base type.
Will fix.
WalterBright
added a commit
that referenced
this pull request
May 22, 2012
Issue 7909 - to!enum(string) and to!string(enum) break when enum is integral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=7909