Issue 7878 - A problem with purity and general templated algorithms #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to close Issue 5505 as well, since it references |
| // else | ||
| // { | ||
| // alias comp binaryFun; | ||
| // } | ||
| } | ||
|
|
||
| unittest |
There was a problem hiding this comment.
If you change /* to /** on line 142 you would fix Issue 5358
Marked as a duplicate of bug 7878. |
| @@ -6782,7 +6782,8 @@ sort(alias less = "a < b", SwapStrategy ss = SwapStrategy.unstable, | |||
| Range)(Range r) | |||
| { | |||
| alias binaryFun!(less) lessFun; | |||
| static if (is(typeof(lessFun(r.front, r.front)) == bool)) | |||
| alias typeof(lessFun(r.front, r.front)) LessRet; // instantiate lessFun | |||
| static if (is(LessRet == bool)) | |||
There was a problem hiding this comment.
So, is the point of this to make it so that when lessFun(r.front, r.front) fails to compile, you get the instantiation error rather than the static if's condition silently evaluating to false?
There was a problem hiding this comment.
Yes. Today template instantiation error trace is enough useful, and shows the real problem why you fail to compile less predicate.
jmdavis
added a commit
that referenced
this pull request
Jun 4, 2012
Issue 7878 - A problem with purity and general templated algorithms
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=7878
Today template instantiation backtrace is implemented, so suppress errors is not useful.