Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 17482: Fix Nullable!Variant equality checks. #5541

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Fix issue 17482: Fix Nullable!Variant equality checks. #5541

merged 1 commit into from
Jul 7, 2017

Conversation

jmdavis
Copy link
Member

@jmdavis jmdavis commented Jul 5, 2017

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 5, 2017 •
edited
Loading

Thanks for your pull request, @jmdavis!

Bugzilla references

Auto-close Bugzilla Description
✓ 17482 [REG 2.074] comile error: Comparing Nullable!Variant with basic type

@jmdavis
Copy link
Member Author

jmdavis commented Jul 5, 2017

The circleci stuff seems to be complaining about something in std.json which wasn't even touched by this PR.

@jmdavis jmdavis mentioned this pull request Jul 5, 2017
Merged
@RazvanN7
Copy link
Collaborator

RazvanN7 commented Jul 5, 2017 •
edited
Loading

I suggest adding a unittest which tests opEquals for other value types, e.g. fixed length arrays.

@CyberShadow
Copy link
Member

The circleci stuff seems to be complaining about something in std.json which wasn't even touched by this PR.

Oops, that looks like my fault.

@wilzbach wilzbach mentioned this pull request Jul 6, 2017
Merged
@wilzbach
Copy link
Member

wilzbach commented Jul 6, 2017

The circleci stuff seems to be complaining about something in std.json which wasn't even touched by this PR.
Oops, that looks like my fault.

-> #5560

wilzbach
wilzbach approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlang-bot dlang-bot merged commit d07b101 into dlang:stable Jul 7, 2017
@jmdavis jmdavis deleted the issue_17482 branch January 28, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzbach wilzbach wilzbach approved these changes

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmdavis @dlang-bot @RazvanN7 @CyberShadow @wilzbach