Fix issue 17711: std.array.byPair ought to work with const AA's. #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quickfur
requested review from
JackStouffer,
wilzbach and
PetarKirov
as code owners
schveiguy
approved these changes
Aug 1, 2017
std/array.d
Outdated
| int[string] aa; | ||
| } | ||
| A a; | ||
| static assert(is(typeof(a))); |
There was a problem hiding this comment.
Hm... I'm not sure you need a special assert for this as you just declared it 😉
I'm going to go out on a limb, and say we don't need this extra test.
There was a problem hiding this comment.
You mean the entire class definition? I'd tend to agree... I just thought it was extra insurance in case something else about the user's code may cause things to break.
There was a problem hiding this comment.
Yes, I think you can nix the whole class definition, it isn't adding any clarity (and it also adds a couple of uncovered lines since you don't actually run it).
|
Thanks, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's nothing about the implementation of
byPairthat precludes it from being used with const AA's, other than the way it's declared.