Fix Issue 8039 - scoped doesn't call any elaborate destructors for struct fields
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3178,6 +3155,29 @@ unittest | |||
|
|
|||
| unittest | |||
| { | |||
| static int dels; | |||
There was a problem hiding this comment.
Please add issue number as a comment.
…struct fields Phobos isn't a place for runtime stuff like `destroy`. And Phobos developers aren't people who should write/check such stuff.
Added. |
9rnsr
added a commit
that referenced
this pull request
May 7, 2012
Fix Issue 8039 - `scoped` doesn't call any elaborate destructors for struct fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phobos isn't a place for runtime stuff like
destroy. And Phobos developers aren't people who should write/check such stuff.I hope error prone functions like
destroy(removed in this pull) will be rejected by Phobos maintainers in future.If anybody is curious why
__dtorisn't working, see this:http://d.puremagic.com/issues/show_bug.cgi?id=5667
Any criticism like "you bastard deleting our functions!" will be accepted.