Small clean-ups of architecture-specific code in FloatingPointControl #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Ping? |
It's value is the same as FloatingPointControl.allExceptions
…trol.ExceptionMask
…trol.ControlState
andralex
approved these changes
Oct 28, 2017
| */ | ||
| roundToNearest, | ||
| roundDown, /// ditto | ||
| roundUp, /// ditto | ||
| roundToZero /// ditto | ||
| roundToZero, /// ditto | ||
| roundingMask, /// ditto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight continuation of #4272.
Changes:
FloatingPointControl.roundingMask: New public RoundingMode valueFloatingPointControl.ExceptionMask: New public base type for exception mask enum.EXCEPTION_MASK,ROUNDING_MODE: Remove internal values.Now, the only parts that need changing for adding ports are FPU exception masks, and the asm code which gets/set the control word.