fix issue 18349 - std/math.d(543,33): Deprecation: integral promotion not done for -x #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Thanks for your pull request, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla references
|
schveiguy
requested changes
Feb 7, 2018
std/math.d
Outdated
| { | ||
| static if (isFloatingPoint!(Num)) | ||
| return fabs(x); | ||
| else | ||
| { | ||
| static if (is(Num == short) || is(Num == byte)) | ||
| static if (is(Num : const(short)) || is(Num : const(byte))) |
There was a problem hiding this comment.
Note, this isn't the same. ubyte, char, wchar, etc. are going to pass these.
I suggest is(Unqual!Num == short)
schveiguy
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last fix was incomplete. abs didn't handle type constructors yet.