Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue renaming std.traits.*Tuple as per #3264 #6227

Closed
wants to merge 1 commit into from

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Feb 27, 2018

Continue renaming of templates resolving to a sequence, but are named as *Tuple.
Some new names don't follow the pattern (shown in italic):

  • ParameterIdentifierTuple -> ParameterNames (consistency with FieldNames, shorter)
  • ParameterStorageClassTuple -> ParameterStorageClasses
  • BaseClassesTuple -> BaseClasses
  • BaseTypeTuple -> BaseTypes
  • InterfacesTuple -> BaseInterfaces (consistency with above two, interfaces can inherit too)
  • FieldNameTuple -> FieldNames
  • MemberFunctionsTuple -> MemberOverloads (more precise as it takes a member name argument)
  • RepresentationTypeTuple -> RepresentationTypes
  • TransitiveBaseTypeTuple -> TransitiveBaseTypes
  • isTypeTuple -> isTypes (to match the isExpressionTuple -> isExpressions change)

As #3264 didn't deprecate the legacy aliases, I haven't done so either. BTW that pull did make the following changes, which I think are inaccurate:

  • ParameterTypeTuple -> Parameters
  • FieldTypeTuple -> Fields

I would prefer those aliases were ParameterTypes and FieldTypes. Mentioning now as it may be a good time to fix those too.

Add legacy aliases.

* ParameterIdentifierTuple -> *ParameterNames* (consistency with FieldNames)
* ParameterStorageClassTuple -> ParameterStorageClasses
* BaseClassesTuple -> BaseClasses
* BaseTypeTuple -> BaseTypes
* InterfacesTuple -> *BaseInterfaces*
* FieldNameTuple -> FieldNames
* MemberFunctionsTuple -> *MemberOverloads* (more precise)
* RepresentationTypeTuple -> RepresentationTypes
* TransitiveBaseTypeTuple -> TransitiveBaseTypes
* isTypeTuple -> isTypes
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@JackStouffer
Copy link
Member

This needs a changelog entry.

Also, I'd argue that deprecations should be added onto these aliases. Any objections?

@MetaLang
Copy link
Member

They probably weren't deprecated back in 2015 because we weren't as worried about breaking code. I agree with @JackStouffer.

@wilzbach
Copy link
Member

Also, I'd argue that deprecations should be added onto these aliases. Any objections?

I tried to revive this too: #4954

Andrei closed it with:

This seems to be a pass that someone made through a personal project after finding a nicer naming convention. I think it breaks too many things for too little benefit.

So yeah, it looks like we can't deprecate the aliases, but imho we should still do the renames.

BTW there was also #4968 which didn't get any interest at that time.

@andralex
Copy link
Member

No more grand renamings please.

@JackStouffer
Copy link
Member

Well, since Andrei is in charge of names I think it's safe to close this.

@ntrel
Copy link
Contributor Author

ntrel commented Jun 27, 2023

Would this be appropriate for std2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants