Fix Issue 18624 - wrong behavior of getSymbolsByUDA if one of the symbols having th…

[Spoov]

…e UDA is a function

The last change to getSymbolsByUDA introduced a bug, causing it to ignore some symbols

[dlang-bot]

Thanks for your pull request and interest in making D better, @Spoov! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	18624	regression	getSymbolsByUDA produces wrong result if one of the symbols having the UDA is a function

[wilzbach]

Why don't you check the result directly?
(would be more robust)

A simple way would be getSymbolsByUDA!(A, Attr).stringof == "tuple(a, a, c)"

[wilzbach]

As this is a regression it would be great if you could open an issue for it and reference it in the commit message (git commit --amend).

Also it should be rebased to stable:

git rebase --onto upstream/stable upstream/master

See the message of dlang-bot for details.

[wilzbach]

See also #6292 - that's why linking to the PR is a good idea ...

[Spoov]

This is my first Pull Request / Issue here so i didn't tough of doing it. I hope i remember doing it next time :)

[wilzbach]

No worries. Nobody is perfect - especially on the first run.
Thanks a lot for your contribution! This will be part of of 2.079.1 - it will be released ~ 1.4.18