Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] fix issue 18837 - MMFile should have opDollar #6521

Merged
merged 1 commit into from May 29, 2018
Merged

[trivial] fix issue 18837 - MMFile should have opDollar #6521

merged 1 commit into from May 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2018

No description provided.

@ghost ghost requested a review from andralex as a code owner May 26, 2018 02:19
@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label May 26, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18837 enhancement MMFile should have opDollar

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6521"

@dlang-bot dlang-bot merged commit 0df8d33 into dlang:master May 29, 2018
@ghost ghost deleted the issue-18837 branch May 29, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants