Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 18993 (REG ~master) - toLower is broken for UTF chars #6586

Merged
merged 1 commit into from Jun 18, 2018
Merged

fix issue 18993 (REG ~master) - toLower is broken for UTF chars #6586

merged 1 commit into from Jun 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2018

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 17, 2018

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18993 regression toLower is broken for UTF chars

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#6586"

@ghost ghost requested a review from DmitryOlshansky as a code owner June 17, 2018 08:04
@ghost ghost changed the title fix 18993 - toLower is broken for UTF chars fix issue 18993 - toLower is broken for UTF chars Jun 17, 2018
@ghost ghost changed the title fix issue 18993 - toLower is broken for UTF chars fix issue 18993 (REG ~master) - toLower is broken for UTF chars Jun 17, 2018
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fast PR!

@ghost
Copy link
Author

ghost commented Jun 18, 2018

ping, there's a problem with the project tester here.

@wilzbach
Copy link
Member

Yep - https://ci.dlang.io is offline.

@wilzbach wilzbach merged commit 238fb76 into dlang:stable Jun 18, 2018
@ghost ghost deleted the issue-18993 branch June 18, 2018 19:24
@Temtaime
Copy link
Contributor

@bbasile would it go to master branch ?

@ghost
Copy link
Author

ghost commented Jun 24, 2018

I can try but this must be this is usually done by the release czar or at least a member.

@ghost
Copy link
Author

ghost commented Jun 24, 2018

Unfortunately This cant be cherry picked due to a conflict. Don't know if they'll take it (commit hash will be different)

@ghost
Copy link
Author

ghost commented Jun 24, 2018

@Temtaime , see #6605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants