Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 11052 - pathSplitter cannot be converted to string[], and to!() fails #6679

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Aug 25, 2018

to now works on pathSplitterresult using the cast operator overloading. Since the function returns a lazy range there's very little chances that anyone ever used cast on it (which would stop working with this change).

@ghost ghost requested review from CyberShadow and kyllingstad as code owners August 25, 2018 16:02
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11052 normal pathSplitter cannot be converted to string[], and to!() template fails

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6679"

@ghost
Copy link
Author

ghost commented Aug 25, 2018

Actually this is more an enhancement; to has no overload that converts input ranges to arrays.

@ghost
Copy link
Author

ghost commented Aug 25, 2018

This is useless actually.

@ghost ghost closed this Aug 25, 2018
@ghost ghost deleted the issue-11052 branch August 25, 2018 20:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants