Add const attribute more strictly #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -824,7 +824,7 @@ class Element : Item | |||
| * if (e1 == e2) { } | |||
| * -------------- | |||
| */ | |||
| override bool opEquals(const Object o) | |||
| override const bool opEquals(const Object o) | |||
There was a problem hiding this comment.
I see you use trailing const everywhere except starting here... not an issue but stylistic uniformity would be good to have.
andralex
added a commit
that referenced
this pull request
Jul 10, 2012
Add const attribute more strictly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supplemental change of dmd/pull/1042, but just is required to avoid project breakage.
You can merge this change without compiler fix.