Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 19740 - Incorrect result of BigInt * BigInt. #6972

Merged
merged 1 commit into from Apr 21, 2019
Merged

Fix issue 19740 - Incorrect result of BigInt * BigInt. #6972

merged 1 commit into from Apr 21, 2019

Conversation

shove70
Copy link
Contributor

@shove70 shove70 commented Apr 21, 2019

Fix issue 19740.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @shove70! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6972"

@thewilsonator
Copy link
Contributor

Please make sure the commit message contains "Fix issue 19740" so that its is picked up by the bot.

@shove70 shove70 changed the title Fixes #19740: Incorrect result of BigInt * BigInt. Fix issue 19740 - Incorrect result of BigInt * BigInt. Apr 21, 2019
@dlang-bot dlang-bot merged commit c6bfb9f into dlang:master Apr 21, 2019
@n8sh
Copy link
Member

n8sh commented Apr 22, 2019

@thewilsonator the bot didn't pick this up because it looks at commit messages rather than PR titles. At this point what's the the right thing to make the bug get closed and the fix noted in the changelog?

@thewilsonator
Copy link
Contributor

Add another PR that has the correct commit message and provide a link to this PR from it, or add a changelog entry directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants