Implement Phobos side of DIP1014 #7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesderid
commented
Jun 16, 2019
| @@ -3791,6 +3792,47 @@ template hasElaborateDestructor(S) | |||
| static assert( hasElaborateDestructor!S7); | |||
| } | |||
|
|
|||
| /** | |||
| True if `S` or any type embedded directly in the representation of `S` | |||
| defines elaborate move semantics. Elaborate move semantics are | |||
There was a problem hiding this comment.
I'm not sure if I like 'elaborate move semantics', but the DIP doesn't propose any terminology. Ideas?
|
Ping, the druntime pr has been merge, can you re-base this? |
lesderid
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Rebased and checks passed. |
thewilsonator
approved these changes
Jul 1, 2019
thewilsonator
approved these changes
Jul 1, 2019
MoonlightSentinel
added a commit
to MoonlightSentinel/druntime
that referenced
this pull request
Jun 10, 2020
n8sh
pushed a commit
to n8sh/druntime
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Phobos side of DIP1014.
Needs dlang/druntime#2638 to be merged first.