Revert "Fix Issue 19105 - Bogus recursive template expansion via getS…

[Biotronic]

…ymbolsByUDA"

This reverts commit 86733d5.

Since PR 7100 did absolutely nothing to actually fix issue 19105 (it's a DMD issue, not a Phobos one), and instead disallows perfectly valid code, it should be reverted.

[dlang-bot]

Thanks for your pull request and interest in making D better, @Biotronic! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19105	normal	Bogus recursive template expansion via getSymbolsByUDA
✓	20054	regression	getSymbolsByUDA no longer works on modules

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7158"

[thewilsonator]

cc @RazvanN7

[PetarKirov]

If I understand correctly, by reverting bug 20054 should also be fixed. Can you add a test for it in a separate commit?

[Biotronic]

Done. However, this PR does not fix issue 19105. Is there some way I can tell the bot this?

[RazvanN7]

Squash your commits and make sure that there aren't any commits that have "Fix Issue 19105" in the commit meesage. The bot links to the issue if those magic words are present.

[John-Colvin]

As a regression fix shouldn't this target stable?

[PetarKirov]

Merging manually as the 'Windows_OMF x86' failure on Azure Pipelines is unrelated.