Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.zip: Update and correct main documentation #7199

Merged
merged 1 commit into from Sep 26, 2019
Merged

std.zip: Update and correct main documentation #7199

merged 1 commit into from Sep 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2019

I replaced the link below "zip archive" to the wikipedia entry, because the old link points to the zip/unzip utility webpage which contains information about this utility but not about zip archieves in general.

Further: From the 6 listed bugs, the first four are no bugs, but just limitations of the current implementation. Bug 592 is "won't fix", refering to D1; Bug 2137 is allready fixed. Therefore I removed the two real bugs and replaced the headline by "Limitations".

@ghost ghost requested a review from CyberShadow as a code owner September 26, 2019 14:45
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @crocopaw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7199"

* Makes use of the etc.c.zlib compression library.
*
* Bugs:
* Limitations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlang-bot dlang-bot merged commit d9c950a into dlang:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants