-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 15891 - Compiler error when std.algorithm.cache after 2 layers of std.algorithm.map #7302
Conversation
|
Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7302" |
std/algorithm/iteration.d
Outdated
| static if (bidir) | ||
| caches[1] = source.back; | ||
| } | ||
| else // needed, because the compiler cannot deduce, that 'caches' is initialized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the comment. Please include a link to the issue that this is fixing so someone can look it up if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the number of the issue. I hope this is what you meant with "link", because weblinks to bugreports are quite uncommon in Phobos - I couldn't find a single one...
| @@ -380,7 +392,11 @@ private struct _Cache(R, bool bidir) | |||
| if (!source.empty) | |||
| caches[0] = source.front; | |||
| else | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment here as well please.
| @@ -389,7 +405,10 @@ private struct _Cache(R, bool bidir) | |||
| if (!source.empty) | |||
| caches[1] = source.back; | |||
| else | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
layers of std.algorithm.map
|
ping? |
Let's make the compiler happy...