Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 15891 - Compiler error when std.algorithm.cache after 2 layers of std.algorithm.map #7302

Merged
merged 1 commit into from Jan 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2019

Let's make the compiler happy...

@ghost ghost requested review from andralex, JackStouffer and wilzbach as code owners December 4, 2019 13:18
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15891 normal Compiler error when std.algorithm.cache after 2 layers of std.algorithm.map

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7302"

static if (bidir)
caches[1] = source.back;
}
else // needed, because the compiler cannot deduce, that 'caches' is initialized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the comment. Please include a link to the issue that this is fixing so someone can look it up if necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the number of the issue. I hope this is what you meant with "link", because weblinks to bugreports are quite uncommon in Phobos - I couldn't find a single one...

@@ -380,7 +392,11 @@ private struct _Cache(R, bool bidir)
if (!source.empty)
caches[0] = source.front;
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment here as well please.

@@ -389,7 +405,10 @@ private struct _Cache(R, bool bidir)
if (!source.empty)
caches[1] = source.back;
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@atilaneves atilaneves added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 8, 2020
@ghost
Copy link
Author

ghost commented Jan 13, 2020

ping?

@thewilsonator thewilsonator added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Jan 13, 2020
@dlang-bot dlang-bot merged commit 495916b into dlang:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants