Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 15940 - ImplicitConversionTargets and class alias in struct #7313

Merged
merged 1 commit into from Dec 12, 2019
Merged

Fix Issue 15940 - ImplicitConversionTargets and class alias in struct #7313

merged 1 commit into from Dec 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2019

Based on PR #4342. I don't really completely understand the implications of this change, but all tests pass and as the original PR has been more or less approved by JackStouffer and I think, that PR was only closed, because the author of the PR left, I resubmit it.

@ghost ghost requested a review from andralex as a code owner December 10, 2019 14:33
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15940 normal ImplicitConversionTargets and class alias in struct

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7313"

@thewilsonator thewilsonator added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Dec 10, 2019
@thewilsonator thewilsonator added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Dec 12, 2019
@dlang-bot dlang-bot merged commit e92a087 into dlang:master Dec 12, 2019
@FeepingCreature
Copy link
Contributor

As a side effect, this introduced a "bug" - class A; ImplicitConversionTargets!(const A) is now wrongly (Object) instead of, as previous, wrongly (). Correct would be (const Object).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants