-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 9298 - some std.math functions not implemented for Win64 #7360
Conversation
|
Thanks for your pull request and interest in making D better, @e10s! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7360" |
|
Please don't auto-merge - DMD still ships with VS 2010 import libs, which doesn't provide these functions [edit: IIRC; MSDN doesn't provide any infos for versions < 2015 anymore]. |
|
Hmm, I was under an illusion. I have to test with This depends on dlang/installer#377? |
|
Heh yeah, great that you've found it yourself. :) - That, in combination with a switch to the VS 2015/UCRT libs, should work; but that requires testing and some further adaptations wrt. linker symbol aliases (which would already be in LDC's Phobos and just need to be moved here upstream). Btw, LDC's libs are a bit newer than those in dlang/installer#377, see https://github.com/ldc-developers/mingw-w64-libs (where you can also download the generated import libs directly). |
|
Is this good to go? |
|
@kinke is this good to go? |
|
AFAIK, DMD now defaults to the MinGW-based libs for the VS2013 runtime (which is already a big improvement over the previous VS2010 ones). So someone needs to check whether these functions are available in VS2013. |
|
cc @rainers do you know? |
|
Finally tested now: std.math unittests in this PR link and run fine with -mscrtlib=msvcrt120 (but not earlier), so should be good to go. |
To be precise, for -m32mscoff / -m64.