Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 8388 - std.traits.MemberFunctionsTuple doesn't work with constructors or destructors #7385

Merged
merged 1 commit into from Jan 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2020

It's essentially a copy of #5710 from @RazvanN7 but with the problematic static this commented out. I tried to hunt down the problem of this static this with dustmite (took two weeks to run) and finally ended up with issue 20529, but as I forgot to include the dependency cycle in the test for dustmite I ended up with a different cycle. Not sure if a fix of 20529 will fix this too or if there is more to discover.

Anyway, IMHO this static this is only a minor point and should not hinder fixing the original bug.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
8388 normal std.traits.MemberFunctionsTuple doesn't work with constructors or destructors

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7385"

@Geod24
Copy link
Member

Geod24 commented May 1, 2020

This broke Vibe.d: vibe-d/vibe.d#2438 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants