Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 20548 - Use bit vector instead of bool[] in RandomCover when choices cannot be packed in a single word #7387

Merged
merged 1 commit into from Jan 31, 2020
Merged

Fix Issue 20548 - Use bit vector instead of bool[] in RandomCover when choices cannot be packed in a single word #7387

merged 1 commit into from Jan 31, 2020

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Jan 31, 2020

No description provided.

@n8sh n8sh requested a review from wilzbach as a code owner January 31, 2020 06:17
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 20548 enhancement Use bit vector instead of bool[] in RandomCover when choices cannot be packed in a single word

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7387"

thewilsonator
thewilsonator approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

std/random.d Outdated Show resolved Hide resolved
@n8sh
Copy link
Member Author

n8sh commented Jan 31, 2020

Taking off auto-merge to use core.bitop bit testing intrinsics.

@n8sh n8sh removed the auto-merge label Jan 31, 2020
@thewilsonator
Copy link
Contributor

OK, merge it when you're happy.

@dlang-bot dlang-bot merged commit 9fe5cd3 into dlang:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@wilzbach wilzbach Awaiting requested review from wilzbach wilzbach is a code owner

Assignees
No one assigned
Labels
auto-merge Enhancement
Projects
None yet
Milestone
No milestone
3 participants
@n8sh @dlang-bot @thewilsonator