Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 20548 followup: in 32-bit builds RandomCoverChoices allocates more memory than needed for the bit vector #7390

Merged
merged 1 commit into from Feb 3, 2020
Merged

Issue 20548 followup: in 32-bit builds RandomCoverChoices allocates more memory than needed for the bit vector #7390

merged 1 commit into from Feb 3, 2020

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Feb 3, 2020

No description provided.

@n8sh n8sh requested a review from wilzbach as a code owner February 3, 2020 10:01
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
✗ 20548 enhancement Use bit vector instead of bool[] in RandomCover when choices cannot be packed in a single word

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7390"

@dlang-bot dlang-bot merged commit 1c0eb7b into dlang:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@wilzbach wilzbach Awaiting requested review from wilzbach wilzbach is a code owner

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
3 participants
@n8sh @dlang-bot @thewilsonator