Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20585 - std.stdio.File.open() failure leaves File in invalid #7397

Merged
merged 1 commit into from Feb 18, 2020

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Feb 17, 2020

state

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20585 normal std.stdio.File open() failure leaves File in invalid state

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7397"

std/stdio.d Outdated Show resolved Hide resolved
std/stdio.d Outdated Show resolved Hide resolved
std/stdio.d Outdated Show resolved Hide resolved
@kubo39
Copy link
Contributor Author

kubo39 commented Feb 17, 2020

CI failed, couldn't reproduce in my machine. I'll add _p = null for checking.

std/stdio.d Outdated Show resolved Hide resolved
std/stdio.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit 46525f7 into dlang:stable Feb 18, 2020
@kubo39 kubo39 deleted the bugzilla-20585 branch March 5, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants