Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20589 - typeof may give wrong result in case of classes defining opCall operator #7398

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

drug007
Copy link
Contributor

@drug007 drug007 commented Feb 20, 2020

See bugzilla here

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 20, 2020

Thanks for your pull request and interest in making D better, @drug007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20589 normal typeof may give wrong result in case of classes defining opCall operator

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7398"

@drug007
Copy link
Contributor Author

drug007 commented Feb 20, 2020

@wilzbach could you point out where can I add a test for this issue?

@thewilsonator
Copy link
Contributor

Please change the commit message to say Fix issue 20589.

@Geod24
Copy link
Member

Geod24 commented Feb 20, 2020

Please change the commit message to say Fix issue 20589.

Fix issue 20589 - <Issue title>

People watching the core repositories don't want to open every single notification they get, just those that seems relevant to their area of expertise. Likewise, when going through old PR / commits (trying to find where a bug was fixed, regression introduced, or feature added), it is extremely painful to see commit without correct title / description.

@drug007 drug007 changed the title Fix #20589 Fix issue 20589 - typeof may give wrong result in case of classes defining opCall operator Feb 20, 2020
@Geod24
Copy link
Member

Geod24 commented Feb 20, 2020

Thanks for changing the title, but the bot picks up the commit, so you also have to go and edit it.

std/container/array.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit 1b6653c into dlang:master Feb 26, 2020
@drug007 drug007 deleted the patch-3 branch February 26, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants