-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 20589 - typeof may give wrong result in case of classes defining opCall operator
#7398
Conversation
|
Thanks for your pull request and interest in making D better, @drug007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7398" |
|
@wilzbach could you point out where can I add a test for this issue? |
|
Please change the commit message to say |
People watching the core repositories don't want to open every single notification they get, just those that seems relevant to their area of expertise. Likewise, when going through old PR / commits (trying to find where a bug was fixed, regression introduced, or feature added), it is extremely painful to see commit without correct title / description. |
opCall operator
|
Thanks for changing the title, but the bot picks up the commit, so you also have to go and edit it. |
…ining `opCall` operator
See bugzilla here