Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 of sort optimizations #74

Merged
merged 2 commits into from
Jun 9, 2011
Merged

Version 2 of sort optimizations #74

merged 2 commits into from
Jun 9, 2011

Conversation

dsimcha
Copy link
Collaborator

@dsimcha dsimcha commented Jun 3, 2011

I fixed all the little issues with my original version of this. I made a new pull request instead of amending the old one because Git was acting up and that was the easiest way to fix it.

@dnadlinger
Copy link
Member

Could you add a short comment to the pivot function? I must admit that it took me some time until I recognized it…

For the record, the original was pull request 53.

@jmdavis
Copy link
Member

jmdavis commented Jun 3, 2011

You can always use --force with a git-push to redo the branch on github, and it would end up in the original pull request. But creating a new pull request works too.

@andralex
Copy link
Member

andralex commented Jun 8, 2011

Ping? Far as I can tell you're one comment and one line from acceptance. Thanks!

@dsimcha
Copy link
Collaborator Author

dsimcha commented Jun 8, 2011

Yeah, I know. I'm planning to sit down one of these days soon and take care
of a laundry list of loose ends w.r.t. D code I've written.

On Wed, Jun 8, 2011 at 10:28 AM, andralex <
reply@reply.github.com>wrote:

Ping? Far as I can tell you're one comment and one line from acceptance.
Thanks!

Reply to this email directly or view it on GitHub:

#74 (comment)

@andralex
Copy link
Member

andralex commented Jun 9, 2011

lgtm

andralex added a commit that referenced this pull request Jun 9, 2011
Version 2 of sort optimizations
@andralex andralex merged commit ea8be4b into dlang:master Jun 9, 2011
kuettler pushed a commit to kuettler/phobos that referenced this pull request Feb 6, 2018
Separate "generated" dir, fixing dustmite build on OSX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants