Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue 20623 - std.conv.to!string error when argument is an inout float #7413

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

This fixes the regression for the upcoming release but it the should probably reconsidered how inout behaves in heavy templated code

@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 3, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20623 regression std.conv.to!string error when argument is an inout float

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7413"

@burner burner self-assigned this Mar 3, 2020
@MoonlightSentinel
Copy link
Contributor Author

This will be fixed as a side effect of #7407. We should probably cherry-pick/merge that commit to stable and only add the test case.

@MoonlightSentinel MoonlightSentinel force-pushed the inout-to branch 2 times, most recently from 939e569 to 23616e8 Compare March 4, 2020 13:06
is an inout float. This bug was fixed as side effect of dlang#7407.
@MoonlightSentinel MoonlightSentinel changed the base branch from stable to master March 10, 2020 17:00
@MoonlightSentinel MoonlightSentinel changed the title Fix Issue 20623 - std.conv.to!string error when argument is an inout float Add tests for issue 20623 - std.conv.to!string error when argument is an inout float Mar 10, 2020
@MoonlightSentinel
Copy link
Contributor Author

Rebased to master since this didn't make the cut for 2.091.1

@thewilsonator thewilsonator merged commit 9dc26f6 into dlang:master Mar 10, 2020
@MoonlightSentinel MoonlightSentinel deleted the inout-to branch March 8, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants