std.complex: Add complex norm() and proj() #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7475" |
ibuclaw
force-pushed
the
stdcomplex/normproj
branch
from
42b6e4e to
3965b7f
Compare
n8sh
approved these changes
May 13, 2020
|
@n8sh - I take that to mean the current names are fine then. :-) |
ibuclaw
commented
May 14, 2020
ibuclaw
force-pushed
the
stdcomplex/normproj
branch
from
3965b7f to
91f4e2f
Compare
|
@thewilsonator - all fine here? Also, |
|
|
thewilsonator
approved these changes
May 15, 2020
Ready to merge then, can buildkite be retriggered? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple more trivial additions to std.complex, all that remain (future PRs) are a(sin|cos|tan), (sin|cos|tan)h, and possibly isClose.
N.B: should norm be named toNorm?