Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.math: Implement isClose for std.complex types #7482

Merged
merged 2 commits into from
May 15, 2020

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 14, 2020

And updated newly introduced std.complex tests to use isClose instead. More precise numbers have been pulled off from wolfram (example).

@ibuclaw ibuclaw added the math label May 14, 2020
@ibuclaw ibuclaw requested a review from kyllingstad as a code owner May 14, 2020 11:47
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7482"

@ibuclaw ibuclaw requested a review from PetarKirov May 14, 2020 11:49
@ibuclaw
Copy link
Member Author

ibuclaw commented May 14, 2020

Ping @PetarKirov as you requested this. :-)

@ibuclaw
Copy link
Member Author

ibuclaw commented May 14, 2020

@thewilsonator - I don't suppose you really want tests for isClose([complex(1.0)], 1.0), do you? :-)

@ibuclaw
Copy link
Member Author

ibuclaw commented May 14, 2020

Here we go again with inaccurate floating point on x86 targets. :-)

@ibuclaw ibuclaw force-pushed the stdcomplex/isclose branch from ce61945 to 0523359 Compare May 14, 2020 14:09
@ibuclaw
Copy link
Member Author

ibuclaw commented May 14, 2020

src/core/attribute.d(139): Error: typesafe variadic functions have been removed
src/core/internal/atomic.d(1088): Error: typesafe variadic functions have been removed
src/core/time.d(3799): Error: typesafe variadic functions have been removed
src/core/time.d(3833): Error: typesafe variadic functions have been removed

Did someone accidentally hit merge on an experimental compiler feature?

@ibuclaw
Copy link
Member Author

ibuclaw commented May 14, 2020

@thewilsonator - good to go if there's no other issues. Though may give it a short while for @PetarKirov to maybe chime in.

@thewilsonator thewilsonator merged commit 71b8853 into dlang:master May 15, 2020
@ibuclaw ibuclaw deleted the stdcomplex/isclose branch May 15, 2020 05:41
@PetarKirov
Copy link
Member

Thanks @ibuclaw looks good to me for a quick look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants