-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.math: Implement isClose for std.complex types #7482
Conversation
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7482" |
|
Ping @PetarKirov as you requested this. :-) |
|
@thewilsonator - I don't suppose you really want tests for |
|
Here we go again with inaccurate floating point on x86 targets. :-) |
2972ff5 to
ce61945
Compare
ce61945 to
0523359
Compare
Did someone accidentally hit merge on an experimental compiler feature? |
|
@thewilsonator - good to go if there's no other issues. Though may give it a short while for @PetarKirov to maybe chime in. |
|
Thanks @ibuclaw looks good to me for a quick look! |
And updated newly introduced std.complex tests to use isClose instead. More precise numbers have been pulled off from wolfram (example).