std.math: Begin deprecation of accidentally leaked AliasSeq

[ibuclaw]

No, there isn't a better way of doing this. Complements to @schveiguy for an initial version of this PR.

Rebased and updated following dmd fix.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7487"

[MoonlightSentinel]

That workaround is really ugly...

The weird part is that this bug doesn't apply to other deprecated imports, e.g function (templates).

[dnadlinger]

Maybe std.meta.AliasSeq was unintentionally available through std.math and will be removed after …. Please import std.meta instead. or something that makes clear where the symbol came from? If I saw this as an user not too familiar with metaprogramming in D, I would try to look up docs for std.math.AliasSeq to figure out what was going on.

[schveiguy]

The worst part about this is that the deprecation message will be printed for the mixin line, not the usage. However, one possible saving grace is that the full instantiation is printed, so you might be able to deduce where it's coming from based on that.

[schveiguy]

I don't see a deprecation in the D-YAML build log. Was the import of std.meta added? It would be nice to see that this actually works ;)

Edit: yes it was... dlang-community/D-YAML#254

[MoonlightSentinel]

Please don't merge this yet, I think i have a fix for the missing deprecation.

EDIT: See dlang/dmd#11158

[schveiguy]

You need to break this line in half, style check complains.

I'll reapprove if the DMD PR doesn't work out. Just don't want this to be merged prematurely.

[schveiguy]

Should we close this now that dlang/dmd#11158 is merged?

[MoonlightSentinel]

Not really, just add a plain deprecation message?

[schveiguy]

Right, maybe adjust this to properly deprecate the import.

[12345swordy]

@ibuclaw ping

[ibuclaw]

Rebased.