-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 20869 - move is overly trusting of opPostMove
#7502
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7502" |
|
Please target stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
ab3c0a8 to
a604bd3
Compare
Is stable broken? |
a604bd3 to
7e9cfe4
Compare
ec78dd6 to
f00c231
Compare
|
Rebased to master because this might break code relying on the invalid |
f00c231 to
7a9f157
Compare
Remove the manual check whether move is `@safe` and instead let the compiler do the attribute interference by adding appropriate @trusted blocks. Note: I could've extend the current checks `trustedMoveImpl` but that could easily miss other corner cases.
7a9f157 to
082f830
Compare
The broken compilation is because it's using |
Remove the manual check whether move is
@safeand instead let the compiler do the attribute interference by adding appropriate@trustedblocks.Note: I could've extend the current checks
trustedMoveImplbut that could easily miss other corner cases.TLDR: Only use
@trustedwhen necessary