Support construction of std.bigint.BigInt from a sign and a byte-array magnitude #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @n8sh! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7511" |
thewilsonator
approved these changes
Jun 1, 2020
|
Needed to re-push because of an oversight regarding |
|
Fixed the spelling error in the documentation and changed the requirement from |
dkorpel
requested changes
Jun 1, 2020
n8sh
force-pushed
the
issue-20889
branch
2 times, most recently
from
2e083c2 to
7c03fc3
Compare
…gn and a byte-array magnitude For consistency with other std.bigint functions allows arbitrary ranges.
n8sh
added
the
Merge:72h no objection -> merge
|
More than 72 hours has passed. |
thewilsonator
added
Merge:auto-merge
and removed
Merge:72h no objection -> merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other std.bigint functions allows arbitrary ranges.