Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20949 - std.range.popFront is unsafe in release mode #7535

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

aG0aep6G
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20949 normal std.range.popFront is unsafe in release mode

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7535"

@aG0aep6G
Copy link
Contributor Author

I don't know where to add a test for this. The issue only manifests when the assert in popFront is omitted. Apparently, -unittest overrides -release and keeps the assert. So a unittest doesn't cut it. Do we have a place in Phobos for testing a complete program?

@dlang-bot dlang-bot merged commit 95e8303 into dlang:master Jun 19, 2020
@aG0aep6G aG0aep6G deleted the 20949 branch June 22, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants