Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 8904 - revert workaround added to prevent a linker error #7549

Closed
wants to merge 1 commit into from
Closed

fix issue 8904 - revert workaround added to prevent a linker error #7549

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2020

No description provided.

@ghost ghost requested a review from MetaLang as a code owner July 1, 2020 12:04
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
8904 normal ld error: undefined reference to X

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7549"

@ghost ghost changed the title fix issue 8904 - disable workaround prevent linking issue fix issue 8904 - disable workaround added to prevent a linker error Jul 1, 2020
@ghost ghost changed the title fix issue 8904 - disable workaround added to prevent a linker error fix issue 8904 - revert workaround added to prevent a linker error Jul 1, 2020
@ghost
Copy link
Author

ghost commented Jul 1, 2020

this was just to verify if the iussue can be closed as is

@ghost ghost closed this Jul 1, 2020
@ghost ghost deleted the patch-1 branch July 1, 2020 16:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant