Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21183 - schwartzSort does not strip const #7602

Merged
merged 1 commit into from Aug 21, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

Fixed by using the unqualified type if possible

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21183 minor schwartzSort does not strip const

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7602"

Fixed by using the unqualified type if possible
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once CI is green

@MoonlightSentinel
Copy link
Contributor Author

Cannot do that (got no power here).
Anyway, BuildKite will be green once ba02646 is merged into stable.

@wilzbach wilzbach merged commit 598e55e into dlang:stable Aug 21, 2020
@wilzbach
Copy link
Member

Cannot do that (got no power here).
Anyway, BuildKite will be green once ba02646 is merged into stable.

Yeah we should cherry-pick that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants