Fix Issue 21201 - let std.uuid.parseUUID accept input ranges whose elements are char or wchar, not just dchar #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @n8sh! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7607" |
wilzbach
approved these changes
Aug 27, 2020
std/uuid.d
Outdated
| { | ||
| import std.utf : byCodeUnit; | ||
| auto range = "8AB3060E-2CBA-4F23-b74c-B52Db3BDFB46".byCodeUnit; | ||
| assert(parseUUID(range). data == [138, 179, 6, 14, 44, 186, 79, 35, 183, 76, 181, 45, 179, 189, 251, 70]); |
There was a problem hiding this comment.
Phobos style is no whitespace after dot.
…ements are char or wchar, not just dchar All characters of interest to std.uuid.parseUUID are ASCII so there is no reason it cannot work on a range of chars or wchars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All characters of interest to
std.uuid.parseUUIDare ASCII so there is no reason it cannot work on a range ofchars orwchars.