Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 14909: Provided a fix for the forward range version of chunkBy … #7625

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Issue 14909: Provided a fix for the forward range version of chunkBy … #7625

merged 3 commits into from
Sep 23, 2020

Conversation

jamesragray
Copy link

…so that it can accept predicates reference variables in the calling function. Sorry about creating a second pull request but I was having problems with git.

…so that it can accept predicates refernce variables in the calling function
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @jamesragray! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
14909 normal Template argument of std.algorithm.iteration.chunkBy cannot access a local variable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7625"

@n8sh n8sh added Merge:72h no objection -> merge The PR will be merged if there are no objections raised. Merge:auto-merge labels Sep 18, 2020
@dlang-bot dlang-bot merged commit 4d7e582 into dlang:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:auto-merge Merge:72h no objection -> merge The PR will be merged if there are no objections raised.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants