Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21237: isLvalueAssignable and isRvalueAssignable should be … #7626

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Sep 11, 2020

…public

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21237 enhancement isLvalueAssignable and isRvalueAssignable should be public

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7626"

@pbackus
Copy link
Contributor Author

pbackus commented Sep 12, 2020

Auto-tester looks green when I click on "Details"; why is it showing yellow on Github?

@thewilsonator
Copy link
Contributor

Look at the Deleted column, only two are fresh.

@dlang-bot dlang-bot merged commit 33b1c17 into dlang:master Sep 12, 2020
@pbackus pbackus deleted the fix-21237 branch September 13, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants