Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21256 - Segfault with Appender!string.init.toString() #7691

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

e10s
Copy link
Contributor

@e10s e10s commented Nov 11, 2020

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 11, 2020

Thanks for your pull request and interest in making D better, @e10s! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21256 critical Segfault with Appender!string.init.toString()

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7691"

@thewilsonator
Copy link
Contributor

Two things: please update the commit message to match the copyedited issue title and please rebase this PR to stable.

@e10s e10s changed the base branch from master to stable November 12, 2020 06:59
@e10s e10s changed the title Fix Issue 21256 - The toString() in Appender will crash the app Fix Issue 21256 - Segfault with Appender!string.init.toString() Nov 12, 2020
@thewilsonator
Copy link
Contributor

Hmm, please force-push to restart the CI.

@dlang-bot dlang-bot merged commit f3c8d75 into dlang:stable Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants