Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with std.random.uniform!dchar(urng) #7695

Merged
merged 2 commits into from Nov 18, 2020

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Nov 13, 2020

No description provided.

…ds urng and always uses a thread-local random
…g) when T is dchar with any qualifiers can exceed dchar.max
@n8sh n8sh requested a review from wilzbach as a code owner November 13, 2020 15:00
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
21383 normal std.random.uniform!T(urng) when T is dchar disregards urng and always uses a thread-local random
21384 normal std.random.uniform!T() and std.random.uniform!T(urng) when T is dchar with any qualifiers can exceed dchar.max

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7695"

@thewilsonator
Copy link
Contributor

please force push to restart CI

@dlang-bot dlang-bot merged commit d376f52 into dlang:stable Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants